jbd2: round commit timer up to avoid uncommitted transaction
authorAndreas Dilger <adilger@sun.com>
Tue, 11 Aug 2009 02:51:53 +0000 (22:51 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 11 Aug 2009 02:51:53 +0000 (22:51 -0400)
fix jiffie rounding in jbd commit timer setup code.  Rounding down
could cause the timer to be fired before the corresponding transaction
has expired.  That transaction can stay not committed forever if no
new transaction is created or expicit sync/umount happens.

Signed-off-by: Alex Zhuravlev (Tomas) <alex.zhuravlev@sun.com>
Signed-off-by: Andreas Dilger <adilger@sun.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/jbd2/transaction.c

index 6213ac728f303286e15a2b6703fc90d69e2bd6ba..4516a87ca55c3c2fb4867ed7465ceaf272daac9c 100644 (file)
@@ -57,7 +57,7 @@ jbd2_get_transaction(journal_t *journal, transaction_t *transaction)
        INIT_LIST_HEAD(&transaction->t_private_list);
 
        /* Set up the commit timer for the new transaction. */
-       journal->j_commit_timer.expires = round_jiffies(transaction->t_expires);
+       journal->j_commit_timer.expires = round_jiffies_up(transaction->t_expires);
        add_timer(&journal->j_commit_timer);
 
        J_ASSERT(journal->j_running_transaction == NULL);