perf hists browser: Skip scripting when perf.data file not available
authorNamhyung Kim <namhyung@kernel.org>
Tue, 26 Jan 2016 18:37:30 +0000 (15:37 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 26 Jan 2016 19:08:12 +0000 (16:08 -0300)
The script and data-switch context menu are only meaningful when it
deals with a data file.  So add a check so that it cannot be shown when
perf-top is run.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1453555902-18401-4-git-send-email-namhyung@kernel.org
[ Use goto skip_scripting instead of two is_report_browser() tests ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/hists.c

index d07e6be42ab1693e19499a497b9cc3cfc019d956..1da30f8aa7a5e530ffde9cc0157ffb35a92f2e28 100644 (file)
@@ -2303,6 +2303,9 @@ skip_annotation:
                                             &options[nr_options],
                                             socked_id);
                /* perf script support */
+               if (!is_report_browser(hbt))
+                       goto skip_scripting;
+
                if (browser->he_selection) {
                        if (sort__has_thread && thread) {
                                nr_options += add_script_opt(browser,
@@ -2330,6 +2333,7 @@ skip_annotation:
                                             &options[nr_options], NULL, NULL);
                nr_options += add_switch_opt(browser, &actions[nr_options],
                                             &options[nr_options]);
+skip_scripting:
                nr_options += add_exit_opt(browser, &actions[nr_options],
                                           &options[nr_options]);