GFS2: Remove extra "if" in gfs2_log_flush()
authorSteven Whitehouse <swhiteho@redhat.com>
Tue, 25 Feb 2014 11:52:20 +0000 (11:52 +0000)
committerSteven Whitehouse <swhiteho@redhat.com>
Tue, 25 Feb 2014 11:52:20 +0000 (11:52 +0000)
By reordering some of the assignments in gfs2_log_flush() it
is possible to remove one of the "if" statements as it can be
merged with one higher up the function.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/log.c

index c1c9a29fda9ccf6c0bd3a4381b1e0e7e697eac0a..edbd46113c287119ab3163edaeca5952191bd51b 100644 (file)
@@ -684,21 +684,19 @@ void gfs2_log_flush(struct gfs2_sbd *sdp, struct gfs2_glock *gl)
        }
        trace_gfs2_log_flush(sdp, 1);
 
+       sdp->sd_log_flush_head = sdp->sd_log_head;
+       sdp->sd_log_flush_wrapped = 0;
        tr = sdp->sd_log_tr;
        if (tr) {
                sdp->sd_log_tr = NULL;
                INIT_LIST_HEAD(&tr->tr_ail1_list);
                INIT_LIST_HEAD(&tr->tr_ail2_list);
+               tr->tr_first = sdp->sd_log_flush_head;
        }
 
        gfs2_assert_withdraw(sdp,
                        sdp->sd_log_num_revoke == sdp->sd_log_commited_revoke);
 
-       sdp->sd_log_flush_head = sdp->sd_log_head;
-       sdp->sd_log_flush_wrapped = 0;
-       if (tr)
-               tr->tr_first = sdp->sd_log_flush_head;
-
        gfs2_ordered_write(sdp);
        lops_before_commit(sdp, tr);
        gfs2_log_flush_bio(sdp, WRITE);