drm/i915: Organize bind_vma funcs
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 3 Dec 2014 12:55:29 +0000 (04:55 -0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 17 Dec 2014 17:23:12 +0000 (18:23 +0100)
Let's be optimistic that for future platforms this will remain the same
and reorg a bit.
This reorg in if blocks instead of switch make life easier for future
platform support addition.

Cc: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem_gtt.c

index 82cb5666583f745983eef88bb2dc674a23f6ab3c..746f77fb57a314d5b94542b12b67b7a16bfb50eb 100644 (file)
@@ -2243,11 +2243,7 @@ static struct i915_vma *__i915_gem_vma_create(struct drm_i915_gem_object *obj,
        vma->obj = obj;
        vma->ggtt_view = *view;
 
-       switch (INTEL_INFO(vm->dev)->gen) {
-       case 9:
-       case 8:
-       case 7:
-       case 6:
+       if (INTEL_INFO(vm->dev)->gen >= 6) {
                if (i915_is_ggtt(vm)) {
                        vma->unbind_vma = ggtt_unbind_vma;
                        vma->bind_vma = ggtt_bind_vma;
@@ -2255,17 +2251,10 @@ static struct i915_vma *__i915_gem_vma_create(struct drm_i915_gem_object *obj,
                        vma->unbind_vma = ppgtt_unbind_vma;
                        vma->bind_vma = ppgtt_bind_vma;
                }
-               break;
-       case 5:
-       case 4:
-       case 3:
-       case 2:
+       } else {
                BUG_ON(!i915_is_ggtt(vm));
                vma->unbind_vma = i915_ggtt_unbind_vma;
                vma->bind_vma = i915_ggtt_bind_vma;
-               break;
-       default:
-               BUG();
        }
 
        list_add_tail(&vma->vma_link, &obj->vma_list);