drm/mgag200: fix error return code in mgag200fb_create()
authorWei Yongjun <weiyj.lk@gmail.com>
Mon, 15 Aug 2016 15:03:51 +0000 (15:03 +0000)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 16 Aug 2016 07:10:16 +0000 (09:10 +0200)
Fix to return error code -ENOMEM from the vmalloc() error handling
case instead of 0, as done elsewhere in this function.

Fixes: aec9e12953e7 ("drm/mgag200: Fix error handling paths in fbdev driver")
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1471273431-6753-1-git-send-email-weiyj.lk@gmail.com
drivers/gpu/drm/mgag200/mgag200_fb.c

index 81325f64134f6a883ce999f4d9e95a4f588acf71..88dd2214114dcd58d431b6a166ad83fcee5df287 100644 (file)
@@ -183,8 +183,10 @@ static int mgag200fb_create(struct drm_fb_helper *helper,
        }
 
        sysram = vmalloc(size);
-       if (!sysram)
+       if (!sysram) {
+               ret = -ENOMEM;
                goto err_sysram;
+       }
 
        info = drm_fb_helper_alloc_fbi(helper);
        if (IS_ERR(info)) {