myri10ge: use eth_skb_pad helper
authorAlexander Duyck <alexander.h.duyck@redhat.com>
Wed, 3 Dec 2014 16:17:58 +0000 (08:17 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Dec 2014 01:47:42 +0000 (20:47 -0500)
Update myri10ge to use eth_skb_pad helper.  This also corrects a minor
issue as the driver was updating length without updating the tail pointer.

Cc: Hyong-Youb Kim <hykim@myri.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/myricom/myri10ge/myri10ge.c

index 9e7e3f1dce3ea84f4305f8b0665fbd0aad5ac877..af099057f0e9c263dc250924785a15cf75ea6edb 100644 (file)
@@ -2913,16 +2913,11 @@ again:
                flags |= MXGEFW_FLAGS_SMALL;
 
                /* pad frames to at least ETH_ZLEN bytes */
-               if (unlikely(skb->len < ETH_ZLEN)) {
-                       if (skb_padto(skb, ETH_ZLEN)) {
-                               /* The packet is gone, so we must
-                                * return 0 */
-                               ss->stats.tx_dropped += 1;
-                               return NETDEV_TX_OK;
-                       }
-                       /* adjust the len to account for the zero pad
-                        * so that the nic can know how long it is */
-                       skb->len = ETH_ZLEN;
+               if (eth_skb_pad(skb)) {
+                       /* The packet is gone, so we must
+                        * return 0 */
+                       ss->stats.tx_dropped += 1;
+                       return NETDEV_TX_OK;
                }
        }