remove unlock_kernel() left accidentally
authorJ. R. Okajima <hooanon05@yahoo.co.jp>
Tue, 16 Jun 2009 16:16:50 +0000 (01:16 +0900)
committerAl Viro <viro@zeniv.linux.org.uk>
Wed, 17 Jun 2009 04:36:35 +0000 (00:36 -0400)
commit 337eb00a2c3a421999c39c94ce7e33545ee8baa7
Push BKL down into ->remount_fs()
and
commit 4aa98cf768b6f2ea4b204620d949a665959214f6
Push BKL down into do_remount_sb()

were uncorrectly merged.
The former removes one pair of lock/unlock_kernel(), but the latter adds
several unlock_kernel(). Finally a few unlock_kernel() calls left.

Signed-off-by: J. R. Okajima <hooanon05@yahoo.co.jp>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/super.c

index 83b47416d0069bba99e738212a0d673d2b98564e..d40d53a22fb595d3489e1273ac6efb26481b39e1 100644 (file)
@@ -545,24 +545,18 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force)
        if ((flags & MS_RDONLY) && !(sb->s_flags & MS_RDONLY)) {
                if (force)
                        mark_files_ro(sb);
-               else if (!fs_may_remount_ro(sb)) {
-                       unlock_kernel();
+               else if (!fs_may_remount_ro(sb))
                        return -EBUSY;
-               }
                retval = vfs_dq_off(sb, 1);
-               if (retval < 0 && retval != -ENOSYS) {
-                       unlock_kernel();
+               if (retval < 0 && retval != -ENOSYS)
                        return -EBUSY;
-               }
        }
        remount_rw = !(flags & MS_RDONLY) && (sb->s_flags & MS_RDONLY);
 
        if (sb->s_op->remount_fs) {
                retval = sb->s_op->remount_fs(sb, &flags, data);
-               if (retval) {
-                       unlock_kernel();
+               if (retval)
                        return retval;
-               }
        }
        sb->s_flags = (sb->s_flags & ~MS_RMT_MASK) | (flags & MS_RMT_MASK);
        if (remount_rw)