V4L/DVB: cx23885: strcpy() => strlcpy()
authorDan Carpenter <error27@gmail.com>
Tue, 6 Apr 2010 05:26:48 +0000 (02:26 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 19 May 2010 15:56:41 +0000 (12:56 -0300)
cap->driver is a 16 char buffer and dev->name is a 32 char buffer.
I don't see an actual problem, but we may as well make the static
checkers happy.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/cx23885/cx23885-417.c

index a8ddc227cf8643410846737038f92ac892b89015..abd64e89f60f4222d0910b950b825c2393adb30a 100644 (file)
@@ -1356,7 +1356,7 @@ static int vidioc_querycap(struct file *file, void  *priv,
        struct cx23885_dev *dev = fh->dev;
        struct cx23885_tsport  *tsport = &dev->ts1;
 
-       strcpy(cap->driver, dev->name);
+       strlcpy(cap->driver, dev->name, sizeof(cap->driver));
        strlcpy(cap->card, cx23885_boards[tsport->dev->board].name,
                sizeof(cap->card));
        sprintf(cap->bus_info, "PCI:%s", pci_name(dev->pci));