projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: aa96646)
Staging: tm6000: silence Sparse warning "dubious: !x | !y"
authorDan Carpenter <error27@gmail.com>
Mon, 3 Jan 2011 05:47:40 +0000 (08:47 +0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 21 Jan 2011 20:14:47 +0000 (12:14 -0800)
Bitwise and logical or are the equivalent here, so this doesn't affect
runtime, but logical or was intended.  The original code causes a
warning in Sparse:  "warning: dubious: !x | !y"

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/tm6000/tm6000-input.c patch | blob | blame | history

diff --git a/drivers/staging/tm6000/tm6000-input.c b/drivers/staging/tm6000/tm6000-input.c
index 21e7da40f049c2824c289b9da1e41913620fc458..01fcbbe38409d510aafc0b92b64f0201e674da05 100644 (file)
--- a/drivers/staging/tm6000/tm6000-input.c
+++ b/drivers/staging/tm6000/tm6000-input.c
@@ -374,7 +374,7 @@ int tm6000_ir_init(struct tm6000_core *dev)
 
        ir = kzalloc(sizeof(*ir), GFP_KERNEL);
        rc = rc_allocate_device();
-       if (!ir | !rc)
+       if (!ir || !rc)
                goto out;
 
        /* record handles to ourself */