drm/i915: Try to stop sink crc calculation on error.
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 23 Jul 2015 23:35:45 +0000 (16:35 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 29 Jul 2015 08:23:40 +0000 (10:23 +0200)
Right now if we face any kind of error sink crc calculation
stays enabled.

So, let's give a shot and try to stop it anyway if it got enabled.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Rafael Antognolli <rafael.antognolli@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_dp.c

index f1b9f939b4352b31d00b85b46373cc0b51169acc..70a4a37b7f7fc612362cd7a0db670ec6b754dd6d 100644 (file)
@@ -3994,7 +3994,7 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc)
 
        if (drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK_MISC, &buf) < 0) {
                ret = -EIO;
-               goto out;
+               goto stop;
        }
 
        test_crc_count = buf & DP_TEST_COUNT_MASK;
@@ -4003,7 +4003,7 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc)
                if (drm_dp_dpcd_readb(&intel_dp->aux,
                                      DP_TEST_SINK_MISC, &buf) < 0) {
                        ret = -EIO;
-                       goto out;
+                       goto stop;
                }
                intel_wait_for_vblank(dev, intel_crtc->pipe);
        } while (--attempts && (buf & DP_TEST_COUNT_MASK) == test_crc_count);
@@ -4011,14 +4011,15 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc)
        if (attempts == 0) {
                DRM_DEBUG_KMS("Panel is unable to calculate CRC after 6 vblanks\n");
                ret = -ETIMEDOUT;
-               goto out;
+               goto stop;
        }
 
        if (drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_CRC_R_CR, crc, 6) < 0) {
                ret = -EIO;
-               goto out;
+               goto stop;
        }
 
+stop:
        if (drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK, &buf) < 0) {
                ret = -EIO;
                goto out;