projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 79ef87e)
[media] tvp5150: signedness bug in tvp5150_selmux()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 12 Jul 2012 13:47:28 +0000 (10:47 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 30 Jul 2012 23:22:38 +0000 (20:22 -0300)
tvp5150_read() returns negative error codes so this needs to be an int
for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/tvp5150.c patch | blob | blame | history

diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video/tvp5150.c
index 0d897cb1774a7bc5dd4b10951202f0b8d973955f..a751b6c146fdb523a6a8f3c00cdd9edf84f1f716 100644 (file)
--- a/drivers/media/video/tvp5150.c
+++ b/drivers/media/video/tvp5150.c
@@ -257,7 +257,7 @@ static inline void tvp5150_selmux(struct v4l2_subdev *sd)
        int opmode = 0;
        struct tvp5150 *decoder = to_tvp5150(sd);
        int input = 0;
-       unsigned char val;
+       int val;
 
        if ((decoder->output & TVP5150_BLACK_SCREEN) || !decoder->enable)
                input = 8;