SUNRPC: rpcb_getport_sync() passes incorrect address size to rpc_create()
authorChuck Lever <chuck.lever@oracle.com>
Mon, 14 Jan 2008 20:12:08 +0000 (15:12 -0500)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Wed, 30 Jan 2008 07:06:09 +0000 (02:06 -0500)
The variable "sin" is a pointer, so sizeof(sin) is the size of a pointer,
not the size of thing that sin points to.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
net/sunrpc/rpcb_clnt.c

index 8cbdc0a2de4638a15a618214a8309aee22c77815..fa5b8f202d5b3a358e090f484cff3475d4fc228e 100644 (file)
@@ -228,7 +228,7 @@ int rpcb_getport_sync(struct sockaddr_in *sin, u32 prog, u32 vers, int prot)
                __FUNCTION__, NIPQUAD(sin->sin_addr.s_addr), prog, vers, prot);
 
        rpcb_clnt = rpcb_create(NULL, (struct sockaddr *)sin,
-                               sizeof(sin), prot, 2, 0);
+                               sizeof(*sin), prot, 2, 0);
        if (IS_ERR(rpcb_clnt))
                return PTR_ERR(rpcb_clnt);