perf sort: Separate out memory-specific sort keys

Since they're used only for perf mem, separate out them to a different
dimension so that normal user cannot access them by any chance.

For global/local weights, I'm not entirely sure to place them into the
memory dimension.  But it's the only user at this time.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1364991979-3008-3-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index c877982a64d336e7d7736008c3a9e4eae04393c9..669405c9b8a28df614279308c402ce020cd56cb5 100644 (file)
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -871,6 +871,8 @@ repeat:
                        fprintf(stderr, "branch and mem mode incompatible\n");
                        goto error;
                }
+               sort__mode = SORT_MODE__MEMORY;
+
                /*
                 * if no sort_order is provided, then specify
                 * branch-mode specific order

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index a997955085eb813d933490b390722804d58e0b61..1dbf169492506be32ac4175c414d25891b90a0c1 100644 (file)
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -871,14 +871,6 @@ static struct sort_dimension common_sort_dimensions[] = {
        DIM(SORT_PARENT, "parent", sort_parent),
        DIM(SORT_CPU, "cpu", sort_cpu),
        DIM(SORT_SRCLINE, "srcline", sort_srcline),
-       DIM(SORT_LOCAL_WEIGHT, "local_weight", sort_local_weight),
-       DIM(SORT_GLOBAL_WEIGHT, "weight", sort_global_weight),
-       DIM(SORT_MEM_DADDR_SYMBOL, "symbol_daddr", sort_mem_daddr_sym),
-       DIM(SORT_MEM_DADDR_DSO, "dso_daddr", sort_mem_daddr_dso),
-       DIM(SORT_MEM_LOCKED, "locked", sort_mem_locked),
-       DIM(SORT_MEM_TLB, "tlb", sort_mem_tlb),
-       DIM(SORT_MEM_LVL, "mem", sort_mem_lvl),
-       DIM(SORT_MEM_SNOOP, "snoop", sort_mem_snoop),
 };
 
 #undef DIM
@@ -895,6 +887,21 @@ static struct sort_dimension bstack_sort_dimensions[] = {
 
 #undef DIM
 
+#define DIM(d, n, func) [d - __SORT_MEMORY_MODE] = { .name = n, .entry = &(func) }
+
+static struct sort_dimension memory_sort_dimensions[] = {
+       DIM(SORT_LOCAL_WEIGHT, "local_weight", sort_local_weight),
+       DIM(SORT_GLOBAL_WEIGHT, "weight", sort_global_weight),
+       DIM(SORT_MEM_DADDR_SYMBOL, "symbol_daddr", sort_mem_daddr_sym),
+       DIM(SORT_MEM_DADDR_DSO, "dso_daddr", sort_mem_daddr_dso),
+       DIM(SORT_MEM_LOCKED, "locked", sort_mem_locked),
+       DIM(SORT_MEM_TLB, "tlb", sort_mem_tlb),
+       DIM(SORT_MEM_LVL, "mem", sort_mem_lvl),
+       DIM(SORT_MEM_SNOOP, "snoop", sort_mem_snoop),
+};
+
+#undef DIM
+
 static void __sort_dimension__add(struct sort_dimension *sd, enum sort_type idx)
 {
        if (sd->taken)
@@ -957,6 +964,22 @@ int sort_dimension__add(const char *tok)
                return 0;
        }
 
+       for (i = 0; i < ARRAY_SIZE(memory_sort_dimensions); i++) {
+               struct sort_dimension *sd = &memory_sort_dimensions[i];
+
+               if (strncasecmp(tok, sd->name, strlen(tok)))
+                       continue;
+
+               if (sort__mode != SORT_MODE__MEMORY)
+                       return -EINVAL;
+
+               if (sd->entry == &sort_mem_daddr_sym)
+                       sort__has_sym = 1;
+
+               __sort_dimension__add(sd, i + __SORT_MEMORY_MODE);
+               return 0;
+       }
+
        return -ESRCH;
 }
 

diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index 39ff4b86ae84bceb6a28e1d3a4ccd74cb2f90156..0232d476da87f5913f7a1e624eb4f03a5aa9d084 100644 (file)
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -138,14 +138,6 @@ enum sort_type {
        SORT_PARENT,
        SORT_CPU,
        SORT_SRCLINE,
-       SORT_LOCAL_WEIGHT,
-       SORT_GLOBAL_WEIGHT,
-       SORT_MEM_DADDR_SYMBOL,
-       SORT_MEM_DADDR_DSO,
-       SORT_MEM_LOCKED,
-       SORT_MEM_TLB,
-       SORT_MEM_LVL,
-       SORT_MEM_SNOOP,
 
        /* branch stack specific sort keys */
        __SORT_BRANCH_STACK,
@@ -154,6 +146,17 @@ enum sort_type {
        SORT_SYM_FROM,
        SORT_SYM_TO,
        SORT_MISPREDICT,
+
+       /* memory mode specific sort keys */
+       __SORT_MEMORY_MODE,
+       SORT_LOCAL_WEIGHT = __SORT_MEMORY_MODE,
+       SORT_GLOBAL_WEIGHT,
+       SORT_MEM_DADDR_SYMBOL,
+       SORT_MEM_DADDR_DSO,
+       SORT_MEM_LOCKED,
+       SORT_MEM_TLB,
+       SORT_MEM_LVL,
+       SORT_MEM_SNOOP,
 };
 
 /*