mfd: Set da903x bits if new value is different from the old one
authorAxel Lin <axel.lin@gmail.com>
Mon, 31 Oct 2011 06:23:03 +0000 (14:23 +0800)
committerSamuel Ortiz <sameo@linux.intel.com>
Tue, 20 Dec 2011 17:50:56 +0000 (18:50 +0100)
It does not make sense to write new value only when all the bit_mask
bits are zero.
We need to write new value if the bit mask fields of new value is
not equal to old value.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/da903x.c

index 62ce685a79cb5e73ae5cc02a9becd0b6f21781f7..1924b857a0fbf6355d9acfcd96fa387b841c6976 100644 (file)
@@ -182,7 +182,7 @@ int da903x_set_bits(struct device *dev, int reg, uint8_t bit_mask)
        if (ret)
                goto out;
 
-       if ((reg_val & bit_mask) == 0) {
+       if ((reg_val & bit_mask) != bit_mask) {
                reg_val |= bit_mask;
                ret = __da903x_write(chip->client, reg, reg_val);
        }