mm: fix mapping_set_error call in me_pagecache_dirty
authorJeff Layton <jlayton@redhat.com>
Thu, 6 Jul 2017 11:02:19 +0000 (07:02 -0400)
committerJeff Layton <jlayton@redhat.com>
Thu, 6 Jul 2017 11:02:19 +0000 (07:02 -0400)
The error code should be negative.  Since this ends up in the default case
anyway, this is harmless, but it's less confusing to negate it.  Also,
later patches will require a negative error code here.

Link: http://lkml.kernel.org/r/20170525103355.6760-1-jlayton@redhat.com
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/memory-failure.c

index 2527dfeddb003d245ac2e2bd964134030426f777..3c5e0b8162f34b6beeeb88f19ac76bc90ff3c3ca 100644 (file)
@@ -684,7 +684,7 @@ static int me_pagecache_dirty(struct page *p, unsigned long pfn)
                 * the first EIO, but we're not worse than other parts
                 * of the kernel.
                 */
-               mapping_set_error(mapping, EIO);
+               mapping_set_error(mapping, -EIO);
        }
 
        return me_pagecache_clean(p, pfn);