ALSA: trident: Delete an error message for a failed memory allocation in snd_trident_...
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 12 Aug 2017 11:20:16 +0000 (13:20 +0200)
committerTakashi Iwai <tiwai@suse.de>
Sat, 12 Aug 2017 21:25:40 +0000 (23:25 +0200)
Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/trident/trident_main.c

index 4561040520c23150552c31bada1519b3ba9c177f..d9bb6dd9f227d075b9ee4cba25723f61392674f7 100644 (file)
@@ -3363,11 +3363,9 @@ static int snd_trident_tlb_alloc(struct snd_trident *trident)
        trident->tlb.entries_dmaaddr = ALIGN(trident->tlb.buffer.addr, SNDRV_TRIDENT_MAX_PAGES * 4);
        /* allocate shadow TLB page table (virtual addresses) */
        trident->tlb.shadow_entries = vmalloc(SNDRV_TRIDENT_MAX_PAGES*sizeof(unsigned long));
-       if (trident->tlb.shadow_entries == NULL) {
-               dev_err(trident->card->dev,
-                       "unable to allocate shadow TLB entries\n");
+       if (!trident->tlb.shadow_entries)
                return -ENOMEM;
-       }
+
        /* allocate and setup silent page and initialise TLB entries */
        if (snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV, snd_dma_pci_data(trident->pci),
                                SNDRV_TRIDENT_PAGE_SIZE, &trident->tlb.silent_page) < 0) {