tpm: use tpm_transmit_cmd() in tpm2_probe()
authorJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Fri, 17 Jun 2016 08:20:14 +0000 (10:20 +0200)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Thu, 15 Sep 2016 13:04:21 +0000 (16:04 +0300)
It is better to tpm_transmit_cmd() in tpm2_probe() in order to get
consistent command handling throughout the subsystem.

Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
drivers/char/tpm/tpm2-cmd.c

index a5aa8de23c3d9d9bd6cc7b3bcb481898cdb34291..7df55d58c93904374ea0faf9bceaf59cfeb6ccd4 100644 (file)
@@ -941,11 +941,9 @@ int tpm2_probe(struct tpm_chip *chip)
        cmd.params.get_tpm_pt_in.property_id = cpu_to_be32(0x100);
        cmd.params.get_tpm_pt_in.property_cnt = cpu_to_be32(1);
 
-       rc = tpm_transmit(chip, (const u8 *)&cmd, sizeof(cmd), 0);
+       rc = tpm_transmit_cmd(chip, &cmd, sizeof(cmd),  0, NULL);
        if (rc <  0)
                return rc;
-       else if (rc < TPM_HEADER_SIZE)
-               return -EFAULT;
 
        if (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS)
                chip->flags |= TPM_CHIP_FLAG_TPM2;