power: bq24735-charger: Assume not charging when charger is missing

When the charger is missing (disconnected), it is safe to assume that
the charger chip is no charging.

This is especially relevant when a status GPIO is present and the
charger is getting disconnected. bq24735_charger_is_charging will be
triggered due to the interrupt then, it will attempt to read whether it
is charging through i2c, which will fail as the charger is disconnected.

This also fixes that specific issue.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
Signed-off-by: Sebastian Reichel <sre@kernel.org>

diff --git a/drivers/power/supply/bq24735-charger.c b/drivers/power/supply/bq24735-charger.c
index fa454c19ce1747ff27f090766b4acf40c0481a3a..dc460bb03d84f74bca7882b67513ff60feca8ebd 100644 (file)
--- a/drivers/power/supply/bq24735-charger.c
+++ b/drivers/power/supply/bq24735-charger.c
@@ -201,8 +201,12 @@ static bool bq24735_charger_is_present(struct bq24735 *charger)
 
 static int bq24735_charger_is_charging(struct bq24735 *charger)
 {
-       int ret = bq24735_read_word(charger->client, BQ24735_CHG_OPT);
+       int ret;
+
+       if (!bq24735_charger_is_present(charger))
+               return 0;
 
+       ret  = bq24735_read_word(charger->client, BQ24735_CHG_OPT);
        if (ret < 0)
                return ret;