mtd: lpc32xx: drop bitflip_threshold initialization

These drivers don't need to explicitly initialize their bitflip
thresholds. The comment is no longer correct, since nand_scan_tail()
performs this initialization as of the following commit:

    commit ea3b2ea24ef0f2ef9c6795b19cff456195b6728a
    Author: Shmulik Ladkani <shmulik@jungo.com>
    Date:   Fri Jun 8 18:29:06 2012 +0300

        mtd: nand: initialize bitflip_threshold prior to BBT scanning

(It seems there were some parallel efforts on writing/submitting these
drivers, and Shmulik's bug fix.)

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Roland Stigge <stigge@antcom.de>

diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c
index 687478c9f09c9a92aee00bdc595f6b5a8757bc0c..7335346dc1263c14f65779d942f9c28202afe51a 100644 (file)
--- a/drivers/mtd/nand/lpc32xx_mlc.c
+++ b/drivers/mtd/nand/lpc32xx_mlc.c
@@ -721,12 +721,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
        nand_chip->bbt_td = &lpc32xx_nand_bbt;
        nand_chip->bbt_md = &lpc32xx_nand_bbt_mirror;
 
-       /* bitflip_threshold's default is defined as ecc_strength anyway.
-        * Unfortunately, it is set only later at add_mtd_device(). Meanwhile
-        * being 0, it causes bad block table scanning errors in
-        * nand_scan_tail(), so preparing it here. */
-       mtd->bitflip_threshold = nand_chip->ecc.strength;
-
        if (use_dma) {
                res = lpc32xx_dma_setup(host);
                if (res) {

diff --git a/drivers/mtd/nand/lpc32xx_slc.c b/drivers/mtd/nand/lpc32xx_slc.c
index 53a6742e3da39a2e1e43be81cf11be943c07a886..8caef28e07564deb7a21f5902ae6527032951190 100644 (file)
--- a/drivers/mtd/nand/lpc32xx_slc.c
+++ b/drivers/mtd/nand/lpc32xx_slc.c
@@ -840,12 +840,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
        chip->ecc.strength = 1;
        chip->ecc.hwctl = lpc32xx_nand_ecc_enable;
 
-       /* bitflip_threshold's default is defined as ecc_strength anyway.
-        * Unfortunately, it is set only later at add_mtd_device(). Meanwhile
-        * being 0, it causes bad block table scanning errors in
-        * nand_scan_tail(), so preparing it here already. */
-       mtd->bitflip_threshold = chip->ecc.strength;
-
        /*
         * Allocate a large enough buffer for a single huge page plus
         * extra space for the spare area and ECC storage area