backlight: atmel-pwm-bl: fix gpio polarity in remove
authorJohan Hovold <jhovold@gmail.com>
Tue, 12 Nov 2013 23:09:39 +0000 (15:09 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 13 Nov 2013 03:09:21 +0000 (12:09 +0900)
Make sure to honour gpio polarity also at remove so that the backlight is
actually disabled on boards with active-low enable pin.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/backlight/atmel-pwm-bl.c

index 0971a8e78fbdeb494ec4d4ba506d100527226fbb..e21beb6ad9439e1b3690b61df5fd2a7766bced5f 100644 (file)
@@ -205,8 +205,10 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev)
 {
        struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev);
 
-       if (pwmbl->gpio_on != -1)
-               gpio_set_value(pwmbl->gpio_on, 0);
+       if (pwmbl->gpio_on != -1) {
+               gpio_set_value(pwmbl->gpio_on,
+                                       0 ^ pwmbl->pdata->on_active_low);
+       }
        pwm_channel_disable(&pwmbl->pwmc);
        pwm_channel_free(&pwmbl->pwmc);