ieee802154: 6lowpan: cleanup pull of iphc bytes
authorAlexander Aring <alex.aring@gmail.com>
Wed, 2 Sep 2015 12:21:22 +0000 (14:21 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Thu, 17 Sep 2015 11:20:03 +0000 (13:20 +0200)
This patch cleanups the pull of the iphc bytes. We don't need to check
if the skb->len contains two bytes, this will be checked by
lowpan_fetch_skb_u8.

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/ieee802154/6lowpan/rx.c

index c529d9f2561fbc19c6e95b778d0a751656bb9002..4ddf6944503204b9269b52af673efd513b053d75 100644 (file)
@@ -33,14 +33,9 @@ iphc_decompress(struct sk_buff *skb, const struct ieee802154_hdr *hdr)
        void *sap, *dap;
 
        raw_dump_table(__func__, "raw skb data dump", skb->data, skb->len);
-       /* at least two bytes will be used for the encoding */
-       if (skb->len < 2)
-               return -EINVAL;
-
-       if (lowpan_fetch_skb_u8(skb, &iphc0))
-               return -EINVAL;
 
-       if (lowpan_fetch_skb_u8(skb, &iphc1))
+       if (lowpan_fetch_skb_u8(skb, &iphc0) ||
+           lowpan_fetch_skb_u8(skb, &iphc1))
                return -EINVAL;
 
        ieee802154_addr_to_sa(&sa, &hdr->source);