[media] s3c-camif: fix arguments position in a function call
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 2 Jun 2017 03:43:41 +0000 (00:43 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 13 Jun 2017 17:21:24 +0000 (14:21 -0300)
Fix the position of arguments so camif->colorfx_cb, camif->colorfx_cr
are passed in proper order to the camif_hw_set_effect() function.

Addresses-Coverity-ID: 1248800
Addresses-Coverity-ID: 1269141

[s.nawrocki@samsung.com: edited commit message ]
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/s3c-camif/camif-capture.c

index 1b30be72f4f9f1e664fee96b34dbb4b6d150401a..25c7a7d42292fca87ebccda4979e5fcded1c2c9a 100644 (file)
@@ -80,7 +80,7 @@ static int s3c_camif_hw_init(struct camif_dev *camif, struct camif_vp *vp)
        camif_hw_set_test_pattern(camif, camif->test_pattern);
        if (variant->has_img_effect)
                camif_hw_set_effect(camif, camif->colorfx,
-                               camif->colorfx_cb, camif->colorfx_cr);
+                               camif->colorfx_cr, camif->colorfx_cb);
        if (variant->ip_revision == S3C6410_CAMIF_IP_REV)
                camif_hw_set_input_path(vp);
        camif_cfg_video_path(vp);
@@ -364,7 +364,7 @@ irqreturn_t s3c_camif_irq_handler(int irq, void *priv)
                camif_hw_set_test_pattern(camif, camif->test_pattern);
                if (camif->variant->has_img_effect)
                        camif_hw_set_effect(camif, camif->colorfx,
-                                   camif->colorfx_cb, camif->colorfx_cr);
+                                   camif->colorfx_cr, camif->colorfx_cb);
                vp->state &= ~ST_VP_CONFIG;
        }
 unlock: