[PATCH] drivers/net: remove superfluous memset

	This patch covers something like this:

dev = alloc_*dev(...
...
priv = netdev_priv(dev);
memset(priv, 0, sizeof(*priv));

The memset() here is superfluous. alloc_netdev() uses kzalloc()
to allocate needed memory so there is no need to zero the priv region
twice.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
index 5dc89d507e669c96a26097dbaa38a3fad844e614..2812b524edae33585a371045a2c037a241f4c6f3 100644 (file)
--- a/drivers/net/fs_enet/fs_enet-main.c
+++ b/drivers/net/fs_enet/fs_enet-main.c
@@ -956,7 +956,6 @@ static struct net_device *fs_init_instance(struct device *dev,
        SET_MODULE_OWNER(ndev);
 
        fep = netdev_priv(ndev);
-       memset(fep, 0, privsize);       /* clear everything */
 
        fep->dev = dev;
        dev_set_drvdata(dev, ndev);

diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index 48b23c5924061bca10a062c389ee5b70a3d652b3..6dc28b82493511ebf916e55b20ee498d4ec872a7 100644 (file)
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -2956,7 +2956,6 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        SET_NETDEV_DEV(netdev, &pdev->dev);
 
        mgp = netdev_priv(netdev);
-       memset(mgp, 0, sizeof(*mgp));
        mgp->dev = netdev;
        netif_napi_add(netdev, &mgp->napi,
                       myri10ge_poll, myri10ge_napi_weight);

diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index af16553e18b31dd34bab7812d7aa712a0e8cf6e7..dcd66a6b49040ad645374b7ec810699e0eba149a 100644 (file)
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -329,7 +329,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        SET_NETDEV_DEV(netdev, &pdev->dev);
 
        adapter = netdev->priv;
-       memset(adapter, 0 , sizeof(struct netxen_adapter));
 
        adapter->ahw.pdev = pdev;
        adapter->ahw.pci_func  = pci_func_id;

diff --git a/drivers/net/sunlance.c b/drivers/net/sunlance.c
index 68e4f660367d5e1795ffbef7a4fb2fe6e75339ac..e94b752f9f34717c646a736eace53c8945b92508 100644 (file)
--- a/drivers/net/sunlance.c
+++ b/drivers/net/sunlance.c
@@ -1335,7 +1335,6 @@ static int __devinit sparc_lance_probe_one(struct sbus_dev *sdev,
                return -ENOMEM;
 
        lp = netdev_priv(dev);
-       memset(lp, 0, sizeof(*lp));
 
        if (sparc_lance_debug && version_printed++ == 0)
                printk (KERN_INFO "%s", version);

diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
index 04cba6bf3d5477ffb6678e53187cde36e724f624..06838928ef470afe80cfc579406090984c601d57 100644 (file)
--- a/drivers/net/usb/pegasus.c
+++ b/drivers/net/usb/pegasus.c
@@ -1306,7 +1306,6 @@ static int pegasus_probe(struct usb_interface *intf,
        }
 
        pegasus = netdev_priv(net);
-       memset(pegasus, 0, sizeof (struct pegasus));
        pegasus->dev_index = dev_index;
        init_waitqueue_head(&pegasus->ctrl_wait);
 

diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index fa598f0340cf90f5a7d9b5cca48cf0b374a988b1..3b3a57ea26769356dffa1c479568559895ada1f0 100644 (file)
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c
@@ -905,7 +905,6 @@ static int rtl8150_probe(struct usb_interface *intf,
        }
 
        dev = netdev_priv(netdev);
-       memset(dev, 0, sizeof(rtl8150_t));
 
        dev->intr_buff = kmalloc(INTBUFSIZE, GFP_KERNEL);
        if (!dev->intr_buff) {