scsi: set correct completion code in scsi_send_eh_cmnd()
authorHannes Reinecke <hare@suse.de>
Thu, 8 May 2014 06:09:56 +0000 (08:09 +0200)
committerChristoph Hellwig <hch@lst.de>
Mon, 19 May 2014 10:35:11 +0000 (12:35 +0200)
->queuecommand returns '0' for successful command submission,
so we need to set the correct SCSI midlayer return value
when calling scsi_log_completion().

Signed-off-by: Hannes Reinecke <hare@suse.de>
Reported-by: Robert Elliott <elliott@hp.com>
Cc: Stephen Cameron <scameron@beardog.cce.hp.com>
Tested-by: Robert Elliott <elliott@hp.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/scsi_error.c

index abe51eab3dc6b97d64a0fc0322682499d53bd33f..47a1ffc4c904f8aa17269adedc401cd4ce6e5990 100644 (file)
@@ -1029,6 +1029,7 @@ retry:
                rtn = NEEDS_RETRY;
        } else {
                timeleft = wait_for_completion_timeout(&done, timeout);
+               rtn = SUCCESS;
        }
 
        shost->eh_action = NULL;