asus_acpi: remove misleading mask
authorJulia Lawall <julia@diku.dk>
Tue, 4 Mar 2008 23:00:13 +0000 (15:00 -0800)
committerLen Brown <len.brown@intel.com>
Tue, 18 Mar 2008 06:31:34 +0000 (02:31 -0400)
led_out is boolean, so there is no functional change here,
but apparently an extra mask with 1 caused some style checkers
to flag this as logic bug.

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Luca Tettamanti <kronos.it@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/asus_acpi.c

index d25ef961415cefdeebab67ac29f5a5f49d87ff18..44ad90c03c2ecaa615f9e6aa6f5366cc994e1399 100644 (file)
@@ -610,7 +610,7 @@ write_led(const char __user * buffer, unsigned long count,
            (led_out) ? (hotk->status | ledmask) : (hotk->status & ~ledmask);
 
        if (invert)             /* invert target value */
-               led_out = !led_out & 0x1;
+               led_out = !led_out;
 
        if (!write_acpi_int(hotk->handle, ledname, led_out, NULL))
                printk(KERN_WARNING "Asus ACPI: LED (%s) write failed\n",