projects
/
GitHub
/
moto-9609
/
android_kernel_motorola_exynos9610.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0859ffc
)
watchdog: pcwd_usb: overflow in usb_pcwd_send_command()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Fri, 8 Nov 2013 09:24:19 +0000
(
01:24
-0800)
committer
Wim Van Sebroeck
<wim@iguana.be>
Sun, 17 Nov 2013 18:42:18 +0000
(19:42 +0100)
We changed "buf" from being an array of 6 chars to being a pointer this
sizeof(buf) needs to be updated as well.
Fixes:
2ddb8089a7e5
('watchdog: pcwd_usb: Use allocated buffer for usb_control_msg')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/pcwd_usb.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/watchdog/pcwd_usb.c
b/drivers/watchdog/pcwd_usb.c
index 53598e832a2acbed2389cb40112045b109773ed5..b731b5d129bedee728ca195bc032bb24918f5ef0 100644
(file)
--- a/
drivers/watchdog/pcwd_usb.c
+++ b/
drivers/watchdog/pcwd_usb.c
@@
-258,8
+258,8
@@
static int usb_pcwd_send_command(struct usb_pcwd_private *usb_pcwd,
if (usb_control_msg(usb_pcwd->udev, usb_sndctrlpipe(usb_pcwd->udev, 0),
HID_REQ_SET_REPORT, HID_DT_REPORT,
- 0x0200, usb_pcwd->interface_number, buf,
sizeof(buf)
,
- USB_COMMAND_TIMEOUT) !=
sizeof(buf)
) {
+ 0x0200, usb_pcwd->interface_number, buf,
6
,
+ USB_COMMAND_TIMEOUT) !=
6
) {
dbg("usb_pcwd_send_command: error in usb_control_msg for "
"cmd 0x%x 0x%x 0x%x\n", cmd, *msb, *lsb);
}