drm/sysfs: Remove stale comments about calling drm_sysfs_connector_add() multiple...
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 4 Nov 2013 19:18:46 +0000 (21:18 +0200)
committerDave Airlie <airlied@redhat.com>
Wed, 6 Nov 2013 03:41:37 +0000 (13:41 +1000)
drm_connector_sysfs_add() explicitly checks if connector->kdev
is already populated and returns success. So it clearly now allows
being called multiple times. Remove some stale comments to the contrary.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_sysfs.c

index db1c8f958babb1579b5f18dc5415154b22e72f7e..1a35ea53106b860f5a039ec0df9748cad5729da1 100644 (file)
@@ -366,11 +366,6 @@ static struct bin_attribute edid_attr = {
  * properties (so far, connection status, dpms, mode list & edid) and
  * generate a hotplug event so userspace knows there's a new connector
  * available.
- *
- * Note:
- * This routine should only be called *once* for each registered connector.
- * A second call for an already registered connector will trigger the BUG_ON
- * below.
  */
 int drm_sysfs_connector_add(struct drm_connector *connector)
 {
@@ -383,7 +378,6 @@ int drm_sysfs_connector_add(struct drm_connector *connector)
        if (connector->kdev)
                return 0;
 
-       /* We shouldn't get called more than once for the same connector */
        connector->kdev = device_create(drm_class, dev->primary->kdev,
                                        0, connector, "card%d-%s",
                                        dev->primary->index, drm_get_connector_name(connector));