batman-adv: Use net_device_stats from struct net_device
authorTobias Klauser <tklauser@distanz.ch>
Wed, 5 Apr 2017 11:46:31 +0000 (13:46 +0200)
committerSimon Wunderlich <sw@simonwunderlich.de>
Wed, 5 Apr 2017 13:41:24 +0000 (15:41 +0200)
Instead of using a private copy of struct net_device_stats in struct
batadv_priv, use stats from struct net_device.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
net/batman-adv/distributed-arp-table.c
net/batman-adv/soft-interface.c
net/batman-adv/types.h

index 0608fcf99e7b2a70c8bc2a16796b8c7281e3c137..013e970eff393e0550aa250f7e72c27301071552 100644 (file)
@@ -1003,6 +1003,7 @@ bool batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv,
        bool ret = false;
        struct batadv_dat_entry *dat_entry = NULL;
        struct sk_buff *skb_new;
+       struct net_device *soft_iface = bat_priv->soft_iface;
        int hdr_size = 0;
        unsigned short vid;
 
@@ -1061,10 +1062,10 @@ bool batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv,
                if (!skb_new)
                        goto out;
 
-               skb_new->protocol = eth_type_trans(skb_new,
-                                                  bat_priv->soft_iface);
-               bat_priv->stats.rx_packets++;
-               bat_priv->stats.rx_bytes += skb->len + ETH_HLEN + hdr_size;
+               skb_new->protocol = eth_type_trans(skb_new, soft_iface);
+
+               soft_iface->stats.rx_packets++;
+               soft_iface->stats.rx_bytes += skb->len + ETH_HLEN + hdr_size;
 
                netif_rx(skb_new);
                batadv_dbg(BATADV_DBG_DAT, bat_priv, "ARP request replied locally\n");
index f33bee08bd991f1751e347d6c89abde91d9476bb..b223d3cacbae5e4df635bd1ee6a37a2a27bf193b 100644 (file)
@@ -118,7 +118,7 @@ static u64 batadv_sum_counter(struct batadv_priv *bat_priv,  size_t idx)
 static struct net_device_stats *batadv_interface_stats(struct net_device *dev)
 {
        struct batadv_priv *bat_priv = netdev_priv(dev);
-       struct net_device_stats *stats = &bat_priv->stats;
+       struct net_device_stats *stats = &dev->stats;
 
        stats->tx_packets = batadv_sum_counter(bat_priv, BATADV_CNT_TX);
        stats->tx_bytes = batadv_sum_counter(bat_priv, BATADV_CNT_TX_BYTES);
index 74b5af7dcd86f154cdf4e143db5f13bf3fe90188..76873bf39d75c0cbebe6c727f2664fc900c58561 100644 (file)
@@ -1000,7 +1000,6 @@ struct batadv_priv_bat_v {
  * struct batadv_priv - per mesh interface data
  * @mesh_state: current status of the mesh (inactive/active/deactivating)
  * @soft_iface: net device which holds this struct as private data
- * @stats: structure holding the data for the ndo_get_stats() call
  * @bat_counters: mesh internal traffic statistic counters (see batadv_counters)
  * @aggregated_ogms: bool indicating whether OGM aggregation is enabled
  * @bonding: bool indicating whether traffic bonding is enabled
@@ -1055,7 +1054,6 @@ struct batadv_priv_bat_v {
 struct batadv_priv {
        atomic_t mesh_state;
        struct net_device *soft_iface;
-       struct net_device_stats stats;
        u64 __percpu *bat_counters; /* Per cpu counters */
        atomic_t aggregated_ogms;
        atomic_t bonding;