perf header: Display missing features
authorJiri Olsa <jolsa@kernel.org>
Mon, 10 Oct 2016 07:35:50 +0000 (09:35 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 24 Oct 2016 14:07:34 +0000 (11:07 -0300)
Display missing features in header info, like:

  $ perf report --header-only
  # ========
  # captured on: Mon Oct 10 09:39:47 2016
  ...
  # missing features: HEADER_TRACING_DATA HEADER_CPU_TOPOLOGY ...

To help in diagnosing problems.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-bh5gp84gobdmyl345dcp64se@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/header.c

index 05f5627609587cc7c24d13f20c878e8e00b2794d..d6310c6dace5d5f46c33e6f3501a02c95a5bc2b3 100644 (file)
@@ -2251,7 +2251,7 @@ int perf_header__fprintf_info(struct perf_session *session, FILE *fp, bool full)
        struct perf_header *header = &session->header;
        int fd = perf_data_file__fd(session->file);
        struct stat st;
-       int ret;
+       int ret, bit;
 
        hd.fp = fp;
        hd.full = full;
@@ -2264,6 +2264,14 @@ int perf_header__fprintf_info(struct perf_session *session, FILE *fp, bool full)
 
        perf_header__process_sections(header, fd, &hd,
                                      perf_file_section__fprintf_info);
+
+       fprintf(fp, "# missing features: ");
+       for_each_clear_bit(bit, header->adds_features, HEADER_LAST_FEATURE) {
+               if (bit)
+                       fprintf(fp, "%s ", feat_ops[bit].name);
+       }
+
+       fprintf(fp, "\n");
        return 0;
 }