MIPS: malta-time: Start GIC count before syncing to RTC
authorJames Hogan <james.hogan@imgtec.com>
Fri, 22 Apr 2016 17:19:14 +0000 (18:19 +0100)
committerRalf Baechle <ralf@linux-mips.org>
Fri, 13 May 2016 13:30:25 +0000 (15:30 +0200)
The sampling of the GIC counter on Malta after observing a rising edge
of the RTC update flag differs slightly between the first and second
sample, with the first sample also calling gic_start_count(). The two
samples should really be taken as similarly as possible to get the most
accurate figure, so move the gic_start_count() call before detecting the
rising edge.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/13173/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/mti-malta/malta-time.c

index b7bf721eabf5411bfb2f55b6b7d2cdc9ba887f96..2539687b77f68a454cc56b0f6412af8ae29b2cca 100644 (file)
@@ -81,16 +81,16 @@ static void __init estimate_frequencies(void)
 
        local_irq_save(flags);
 
-       /* Start counter exactly on falling edge of update flag. */
+       if (gic_present)
+               gic_start_count();
+
+       /* Read counter exactly on falling edge of update flag. */
        while (CMOS_READ(RTC_REG_A) & RTC_UIP);
        while (!(CMOS_READ(RTC_REG_A) & RTC_UIP));
 
-       /* Initialize counters. */
        start = read_c0_count();
-       if (gic_present) {
-               gic_start_count();
+       if (gic_present)
                gicstart = gic_read_count();
-       }
 
        /* Read counter exactly on falling edge of update flag. */
        while (CMOS_READ(RTC_REG_A) & RTC_UIP);