ALSA: aoa: Delete an unnecessary check before the function call "snd_pcm_suspend_all"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 3 Jan 2015 19:43:01 +0000 (20:43 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sun, 4 Jan 2015 14:13:03 +0000 (15:13 +0100)
The snd_pcm_suspend_all() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/aoa/soundbus/i2sbus/core.c

index 4e2b4fbf2496817f31a17a1302346225628e86ee..837ba99a7524bc47ae0e4ab2e711195b3e6d59b0 100644 (file)
@@ -381,10 +381,8 @@ static int i2sbus_suspend(struct macio_dev* dev, pm_message_t state)
 
        list_for_each_entry(i2sdev, &control->list, item) {
                /* Notify Alsa */
-               if (i2sdev->sound.pcm) {
-                       /* Suspend PCM streams */
-                       snd_pcm_suspend_all(i2sdev->sound.pcm);
-               }
+               /* Suspend PCM streams */
+               snd_pcm_suspend_all(i2sdev->sound.pcm);
 
                /* Notify codecs */
                list_for_each_entry(cii, &i2sdev->sound.codec_list, list) {