NFS: We must use list_for_each_entry_safe in nfs_access_cache_shrinker
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Wed, 29 Sep 2010 19:11:56 +0000 (15:11 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Wed, 29 Sep 2010 19:16:25 +0000 (15:16 -0400)
We may end up removing the current entry from nfs_access_lru_list.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/dir.c

index 86f1d41c6078b316eb2fb9b8a3976e76b3570dd3..fe549f5ef20f007453d01888916b94c22fb54e5b 100644 (file)
@@ -1788,14 +1788,14 @@ static void nfs_access_free_list(struct list_head *head)
 int nfs_access_cache_shrinker(struct shrinker *shrink, int nr_to_scan, gfp_t gfp_mask)
 {
        LIST_HEAD(head);
-       struct nfs_inode *nfsi;
+       struct nfs_inode *nfsi, *next;
        struct nfs_access_entry *cache;
 
        if ((gfp_mask & GFP_KERNEL) != GFP_KERNEL)
                return (nr_to_scan == 0) ? 0 : -1;
 
        spin_lock(&nfs_access_lru_lock);
-       list_for_each_entry(nfsi, &nfs_access_lru_list, access_cache_inode_lru) {
+       list_for_each_entry_safe(nfsi, next, &nfs_access_lru_list, access_cache_inode_lru) {
                struct inode *inode;
 
                if (nr_to_scan-- == 0)