brcmfmac: change function name for brcmf_cfg80211_wait_vif_event_timeout()
authorArend van Spriel <arend@broadcom.com>
Wed, 17 Feb 2016 10:26:50 +0000 (11:26 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 7 Mar 2016 12:14:37 +0000 (14:14 +0200)
Dropping the '_timeout' from the function name as the fact that a timeout
value is passed makes it obvious a timeout is used. Also helps to keep code
lines a bit shorter and easier to stick to 80 char boundary.

Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c

index d00c5c1d58bf1ce3c13c56cc22d40429be2d4daa..5a4a0c49f933ab16321eabad0588cea121bb0338 100644 (file)
@@ -564,8 +564,8 @@ struct wireless_dev *brcmf_ap_add_vif(struct wiphy *wiphy, const char *name,
        }
 
        /* wait for firmware event */
-       err = brcmf_cfg80211_wait_vif_event_timeout(cfg, BRCMF_E_IF_ADD,
-                                                   BRCMF_VIF_EVENT_TIMEOUT);
+       err = brcmf_cfg80211_wait_vif_event(cfg, BRCMF_E_IF_ADD,
+                                           BRCMF_VIF_EVENT_TIMEOUT);
        brcmf_cfg80211_arm_vif_event(cfg, NULL);
        if (!err) {
                brcmf_err("timeout occurred\n");
@@ -6395,8 +6395,9 @@ bool brcmf_cfg80211_vif_event_armed(struct brcmf_cfg80211_info *cfg)
 
        return armed;
 }
-int brcmf_cfg80211_wait_vif_event_timeout(struct brcmf_cfg80211_info *cfg,
-                                         u8 action, ulong timeout)
+
+int brcmf_cfg80211_wait_vif_event(struct brcmf_cfg80211_info *cfg,
+                                 u8 action, ulong timeout)
 {
        struct brcmf_cfg80211_vif_event *event = &cfg->vif_event;
 
index 40efb539ac26b233cb3888f23dd2083ffdd2dd60..97c327d6d3bb3f51959481373cc20361b31d3bf5 100644 (file)
@@ -402,8 +402,8 @@ bool brcmf_get_vif_state_any(struct brcmf_cfg80211_info *cfg,
 void brcmf_cfg80211_arm_vif_event(struct brcmf_cfg80211_info *cfg,
                                  struct brcmf_cfg80211_vif *vif);
 bool brcmf_cfg80211_vif_event_armed(struct brcmf_cfg80211_info *cfg);
-int brcmf_cfg80211_wait_vif_event_timeout(struct brcmf_cfg80211_info *cfg,
-                                         u8 action, ulong timeout);
+int brcmf_cfg80211_wait_vif_event(struct brcmf_cfg80211_info *cfg,
+                                 u8 action, ulong timeout);
 s32 brcmf_notify_escan_complete(struct brcmf_cfg80211_info *cfg,
                                struct brcmf_if *ifp, bool aborted,
                                bool fw_abort);
index 821b6494f9d11031708153998c1767a88c0b298c..de5892a67c22582cfe66f5d46d3772073fe6eeb0 100644 (file)
@@ -1988,8 +1988,8 @@ int brcmf_p2p_ifchange(struct brcmf_cfg80211_info *cfg,
                brcmf_cfg80211_arm_vif_event(cfg, NULL);
                return err;
        }
-       err = brcmf_cfg80211_wait_vif_event_timeout(cfg, BRCMF_E_IF_CHANGE,
-                                                   BRCMF_VIF_EVENT_TIMEOUT);
+       err = brcmf_cfg80211_wait_vif_event(cfg, BRCMF_E_IF_CHANGE,
+                                           BRCMF_VIF_EVENT_TIMEOUT);
        brcmf_cfg80211_arm_vif_event(cfg, NULL);
        if (!err)  {
                brcmf_err("No BRCMF_E_IF_CHANGE event received\n");
@@ -2090,8 +2090,8 @@ static struct wireless_dev *brcmf_p2p_create_p2pdev(struct brcmf_p2p_info *p2p,
        }
 
        /* wait for firmware event */
-       err = brcmf_cfg80211_wait_vif_event_timeout(p2p->cfg, BRCMF_E_IF_ADD,
-                                                   BRCMF_VIF_EVENT_TIMEOUT);
+       err = brcmf_cfg80211_wait_vif_event(p2p->cfg, BRCMF_E_IF_ADD,
+                                           BRCMF_VIF_EVENT_TIMEOUT);
        brcmf_cfg80211_arm_vif_event(p2p->cfg, NULL);
        brcmf_fweh_p2pdev_setup(pri_ifp, false);
        if (!err) {
@@ -2180,8 +2180,8 @@ struct wireless_dev *brcmf_p2p_add_vif(struct wiphy *wiphy, const char *name,
        }
 
        /* wait for firmware event */
-       err = brcmf_cfg80211_wait_vif_event_timeout(cfg, BRCMF_E_IF_ADD,
-                                                   BRCMF_VIF_EVENT_TIMEOUT);
+       err = brcmf_cfg80211_wait_vif_event(cfg, BRCMF_E_IF_ADD,
+                                           BRCMF_VIF_EVENT_TIMEOUT);
        brcmf_cfg80211_arm_vif_event(cfg, NULL);
        if (!err) {
                brcmf_err("timeout occurred\n");
@@ -2272,8 +2272,8 @@ int brcmf_p2p_del_vif(struct wiphy *wiphy, struct wireless_dev *wdev)
        }
        if (!err) {
                /* wait for firmware event */
-               err = brcmf_cfg80211_wait_vif_event_timeout(cfg, BRCMF_E_IF_DEL,
-                                                       BRCMF_VIF_EVENT_TIMEOUT);
+               err = brcmf_cfg80211_wait_vif_event(cfg, BRCMF_E_IF_DEL,
+                                                   BRCMF_VIF_EVENT_TIMEOUT);
                if (!err)
                        err = -EIO;
                else