mac80211: flush delayed work when entering suspend
authorMatt Chen <matt.chen@intel.com>
Sat, 21 Jan 2017 18:16:58 +0000 (02:16 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 27 Feb 2017 13:00:26 +0000 (14:00 +0100)
The issue was found when entering suspend and resume.
It triggers a warning in:
mac80211/key.c: ieee80211_enable_keys()
...
WARN_ON_ONCE(sdata->crypto_tx_tailroom_needed_cnt ||
             sdata->crypto_tx_tailroom_pending_dec);
...

It points out sdata->crypto_tx_tailroom_pending_dec isn't cleaned up successfully
in a delayed_work during suspend. Add a flush_delayed_work to fix it.

Cc: stable@vger.kernel.org
Signed-off-by: Matt Chen <matt.chen@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/pm.c

index 28a3a0957c9e35af7ffc7b2efb12f1611b7e360b..76a8bcd8ef11237cf8715bf6a10c9085a2152d4d 100644 (file)
@@ -168,6 +168,7 @@ int __ieee80211_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan)
                        break;
                }
 
+               flush_delayed_work(&sdata->dec_tailroom_needed_wk);
                drv_remove_interface(local, sdata);
        }