drm/i915: No need to save/restore irq status in intel_breadcrumbs_fake_irq

Timer callback is a known context so it is correct to always
disable interrupts.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c b/drivers/gpu/drm/i915/intel_breadcrumbs.c
index ba73dc5b03283d4140d4d7d8143709fe24abcd10..1500a1d0e8aa84340edde7093478f66c13d669e3 100644 (file)
--- a/drivers/gpu/drm/i915/intel_breadcrumbs.c
+++ b/drivers/gpu/drm/i915/intel_breadcrumbs.c
@@ -109,7 +109,6 @@ static void intel_breadcrumbs_fake_irq(unsigned long data)
 {
        struct intel_engine_cs *engine = (struct intel_engine_cs *)data;
        struct intel_breadcrumbs *b = &engine->breadcrumbs;
-       unsigned long flags;
 
        /*
         * The timer persists in case we cannot enable interrupts,
@@ -119,10 +118,10 @@ static void intel_breadcrumbs_fake_irq(unsigned long data)
         * coherent seqno check.
         */
 
-       spin_lock_irqsave(&b->irq_lock, flags);
+       spin_lock_irq(&b->irq_lock);
        if (!__intel_breadcrumbs_wakeup(b))
                __intel_engine_disarm_breadcrumbs(engine);
-       spin_unlock_irqrestore(&b->irq_lock, flags);
+       spin_unlock_irq(&b->irq_lock);
        if (!b->irq_armed)
                return;