ipv4: tcp: set SOCK_USE_WRITE_QUEUE for ip_send_unicast_reply()
authorEric Dumazet <edumazet@google.com>
Fri, 1 Apr 2016 15:52:21 +0000 (08:52 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 5 Apr 2016 02:11:20 +0000 (22:11 -0400)
TCP uses per cpu 'sockets' to send some packets :
- RST packets ( tcp_v4_send_reset()) )
- ACK packets for SYN_RECV and TIMEWAIT sockets

By setting SOCK_USE_WRITE_QUEUE flag, we tell sock_wfree()
to not call sk_write_space() since these internal sockets
do not care.

This gives a small performance improvement, merely by allowing
cpu to properly predict the sock_wfree() conditional branch,
and avoiding one atomic operation.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_ipv4.c

index f3ce0afe70aadcb0b1a347a46c281712475218a2..456ff3d6a132235a45e587e416c9362b32331138 100644 (file)
@@ -2384,6 +2384,7 @@ static int __net_init tcp_sk_init(struct net *net)
                                           IPPROTO_TCP, net);
                if (res)
                        goto fail;
+               sock_set_flag(sk, SOCK_USE_WRITE_QUEUE);
                *per_cpu_ptr(net->ipv4.tcp_sk, cpu) = sk;
        }