Prevent the setup callback for page actions to be executed twice

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Page/Action.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Page/Action.js
index db018aaa6cb2833ca0cd3a7a59b617cc768f5f30..bdaf2cf674b75a8a7776e1b3959451f649a0942b 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Page/Action.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Page/Action.js
@@ -32,6 +32,10 @@ define(['Dictionary', 'Language'], function (Dictionary, Language) {
                 * Initializes the page action container.
                 */
                setup: function () {
+                       if (_didInit) {
+                               return;
+                       }
+                       
                        _didInit = true;
                        
                        _wrapper = elCreate('div');
@@ -124,7 +128,7 @@ define(['Dictionary', 'Language'], function (Dictionary, Language) {
                 * @param       {string=}       insertBeforeButton      insert button before element identified by provided button name
                 */
                add: function (buttonName, button, insertBeforeButton) {
-                       if (_didInit === false) this.setup();
+                       this.setup();
                        
                        // The wrapper is required for backwards compatibility, because some implementations rely on a
                        // dedicated parent element to insert elements, for example, for drop-down menus.