drm/bridge: ps8622: Pass flags to devm_gpiod_get()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 19 May 2015 07:03:49 +0000 (09:03 +0200)
committerThierry Reding <treding@nvidia.com>
Tue, 19 May 2015 08:08:04 +0000 (10:08 +0200)
Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
which appeared in v3.17-rc1, the gpiod_get* functions take an additional
parameter that allows to specify direction and initial value for output.

Use this to simplify the driver. Furthermore this is one caller less
that stops us making the flags argument to gpiod_get*() mandatory.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/bridge/ps8622.c

index e895aa7ea353164a157f101c9385ba8ec3986a11..9534607cbd1053d3c1721a733468aa6b7777eaab 100644 (file)
@@ -581,31 +581,21 @@ static int ps8622_probe(struct i2c_client *client,
                ps8622->v12 = NULL;
        }
 
-       ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
+       ps8622->gpio_slp = devm_gpiod_get(dev, "sleep", GPIOD_OUT_HIGH);
        if (IS_ERR(ps8622->gpio_slp)) {
                ret = PTR_ERR(ps8622->gpio_slp);
                dev_err(dev, "cannot get gpio_slp %d\n", ret);
                return ret;
        }
-       ret = gpiod_direction_output(ps8622->gpio_slp, 1);
-       if (ret) {
-               dev_err(dev, "cannot configure gpio_slp\n");
-               return ret;
-       }
 
-       ps8622->gpio_rst = devm_gpiod_get(dev, "reset");
-       if (IS_ERR(ps8622->gpio_rst)) {
-               ret = PTR_ERR(ps8622->gpio_rst);
-               dev_err(dev, "cannot get gpio_rst %d\n", ret);
-               return ret;
-       }
        /*
         * Assert the reset pin high to avoid the bridge being
         * initialized prematurely
         */
-       ret = gpiod_direction_output(ps8622->gpio_rst, 1);
-       if (ret) {
-               dev_err(dev, "cannot configure gpio_rst\n");
+       ps8622->gpio_rst = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
+       if (IS_ERR(ps8622->gpio_rst)) {
+               ret = PTR_ERR(ps8622->gpio_rst);
+               dev_err(dev, "cannot get gpio_rst %d\n", ret);
                return ret;
        }