projects / GitHub / exynos8895 / android_kernel_samsung_universal8895.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 7745cc8)
mfd: Fix off-by-one value range checking for tps6507x
authorAxel Lin <axel.lin@gmail.com>
Wed, 13 Oct 2010 02:44:39 +0000 (10:44 +0800)
committerSamuel Ortiz <sameo@linux.intel.com>
Thu, 28 Oct 2010 22:30:29 +0000 (00:30 +0200)
If bytes == (TPS6507X_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/tps6507x.c patch | blob | blame | history

diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c
index fc01976492816dc7b1cb4570be0d1aad79734569..33ba7723c967435b67c49a6f3f78212a63204b4e 100644 (file)
--- a/drivers/mfd/tps6507x.c
+++ b/drivers/mfd/tps6507x.c
@@ -68,7 +68,7 @@ static int tps6507x_i2c_write_device(struct tps6507x_dev *tps6507x, char reg,
        u8 msg[TPS6507X_MAX_REGISTER + 1];
        int ret;
 
-       if (bytes > (TPS6507X_MAX_REGISTER + 1))
+       if (bytes > TPS6507X_MAX_REGISTER)
                return -EINVAL;
 
        msg[0] = reg;