platform/x86: fujitsu-laptop: simplify set_lcd_level()

acpi_execute_simple_method() takes a method parameter which tells it to
look for the given method underneath the given handle, so calling
acpi_get_handle() beforehand is redundant.  Replace the call to
acpi_get_handle() with a call to acpi_execute_simple_method(), thus
eliminating the need for a local variable storing the handle.  Update
debug message to reflect this change.  Also do not assign a default
value to status as it has no influence on execution flow.

Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Reviewed-by: Jonathan Woithe <jwoithe@just42.net>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>

diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index 46d4f7265d20ae0ce3d7803eeeac028cba9e9a07..066ffe734a5f0a863cbd35a333790ca5784c018e 100644 (file)
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -343,8 +343,7 @@ static enum led_brightness eco_led_get(struct led_classdev *cdev)
 
 static int set_lcd_level(int level)
 {
-       acpi_status status = AE_OK;
-       acpi_handle handle = NULL;
+       acpi_status status;
        char *method;
 
        switch (use_alt_lcd_levels) {
@@ -362,16 +361,14 @@ static int set_lcd_level(int level)
        if (level < 0 || level >= fujitsu_bl->max_brightness)
                return -EINVAL;
 
-       status = acpi_get_handle(fujitsu_bl->acpi_handle, method, &handle);
+       status = acpi_execute_simple_method(fujitsu_bl->acpi_handle, method,
+                                           level);
        if (ACPI_FAILURE(status)) {
-               vdbg_printk(FUJLAPTOP_DBG_ERROR, "%s not present\n", method);
+               vdbg_printk(FUJLAPTOP_DBG_ERROR, "Failed to evaluate %s\n",
+                           method);
                return -ENODEV;
        }
 
-       status = acpi_execute_simple_method(handle, NULL, level);
-       if (ACPI_FAILURE(status))
-               return -ENODEV;
-
        return 0;
 }