ASoC: atmel-pcm-dma: No need to wrap snd_dmaengine_pcm_close()
authorLars-Peter Clausen <lars@metafoo.de>
Fri, 22 Mar 2013 13:12:06 +0000 (14:12 +0100)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Tue, 26 Mar 2013 14:15:24 +0000 (14:15 +0000)
If a PCM driver using the dmaengine PCM helper functions doesn't need to do
anything special in its pcm_close callback, snd_dmaengine_pcm_close can be used
directly for as the pcm_close callback and there is no need to wrap it in a
custom function.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Tested-by: Bo Shen <voice.shen@atmel.com>
Acked-by: Bo Shen <voice.shen@atmel.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/atmel/atmel-pcm-dma.c

index 30184a4a147aa83c7732d9bc6dc61f86d4715b83..396bf78c7a2dda90378a23179e6368c43b953dce 100644 (file)
@@ -199,16 +199,9 @@ static int atmel_pcm_open(struct snd_pcm_substream *substream)
        return 0;
 }
 
-static int atmel_pcm_close(struct snd_pcm_substream *substream)
-{
-       snd_dmaengine_pcm_close(substream);
-
-       return 0;
-}
-
 static struct snd_pcm_ops atmel_pcm_ops = {
        .open           = atmel_pcm_open,
-       .close          = atmel_pcm_close,
+       .close          = snd_dmaengine_pcm_close,
        .ioctl          = snd_pcm_lib_ioctl,
        .hw_params      = atmel_pcm_hw_params,
        .prepare        = atmel_pcm_dma_prepare,