clk: tegra: Fix T210 effective NDIV calculation
authorAlex Frid <afrid@nvidia.com>
Tue, 25 Jul 2017 10:34:07 +0000 (13:34 +0300)
committerStephen Boyd <sboyd@codeaurora.org>
Wed, 23 Aug 2017 22:59:24 +0000 (15:59 -0700)
Don't take the fractional part into account to calculate the effective
NDIV if fractional ndiv is not enabled.

Signed-off-by: Alex Frid <afrid@nvidia.com>
Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
Tested-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/tegra/clk-tegra210.c

index dc4a81328d5ab4657047da93f03029f501e84995..a4d7d94b6436cc6ab356570fa0dc8a5bd5a68b64 100644 (file)
 #define PLL_SDM_COEFF BIT(13)
 #define sdin_din_to_data(din)  ((u16)((din) ? : 0xFFFFU))
 #define sdin_data_to_din(dat)  (((dat) == 0xFFFFU) ? 0 : (s16)dat)
+/* This macro returns ndiv effective scaled to SDM range */
+#define sdin_get_n_eff(cfg)    ((cfg)->n * PLL_SDM_COEFF + ((cfg)->sdm_data ? \
+               (PLL_SDM_COEFF/2 + sdin_data_to_din((cfg)->sdm_data)) : 0))
 
 /* Tegra CPU clock and reset control regs */
 #define CLK_RST_CONTROLLER_CPU_CMPLX_STATUS    0x470
@@ -1288,8 +1291,7 @@ static int tegra210_pll_fixed_mdiv_cfg(struct clk_hw *hw,
                        s -= PLL_SDM_COEFF / 2;
                        cfg->sdm_data = sdin_din_to_data(s);
                }
-               cfg->output_rate *= cfg->n * PLL_SDM_COEFF + PLL_SDM_COEFF/2 +
-                                       sdin_data_to_din(cfg->sdm_data);
+               cfg->output_rate *= sdin_get_n_eff(cfg);
                cfg->output_rate /= p * cfg->m * PLL_SDM_COEFF;
        } else {
                cfg->output_rate *= cfg->n;
@@ -1314,8 +1316,7 @@ static int tegra210_pll_fixed_mdiv_cfg(struct clk_hw *hw,
  */
 static void tegra210_clk_pll_set_gain(struct tegra_clk_pll_freq_table *cfg)
 {
-       cfg->n = cfg->n * PLL_SDM_COEFF + PLL_SDM_COEFF/2 +
-                       sdin_data_to_din(cfg->sdm_data);
+       cfg->n = sdin_get_n_eff(cfg);
        cfg->m *= PLL_SDM_COEFF;
 }