drm/amd/powerplay: fix memory leak of tdp_table
authorColin Ian King <colin.king@canonical.com>
Fri, 18 Mar 2016 16:47:29 +0000 (16:47 +0000)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 21 Mar 2016 15:52:13 +0000 (11:52 -0400)
tdp_table is being leaked on failed allocations of
hwmgr->dyn_state.cac_dtp_table. kfree tdp_table on the error
return path to fix the leak.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c

index 34f4bef3691f863ad581ea34697ccfc3d9628af9..b156481b50e8ee43076abf2de1fdcb8df46f3990 100644 (file)
@@ -512,8 +512,10 @@ static int get_cac_tdp_table(
 
        hwmgr->dyn_state.cac_dtp_table = kzalloc(table_size, GFP_KERNEL);
 
-       if (NULL == hwmgr->dyn_state.cac_dtp_table)
+       if (NULL == hwmgr->dyn_state.cac_dtp_table) {
+               kfree(tdp_table);
                return -ENOMEM;
+       }
 
        memset(hwmgr->dyn_state.cac_dtp_table, 0x00, table_size);