KVM: arm/arm64: arch_timer: Remove irq_phys_map
authorAndre Przywara <andre.przywara@arm.com>
Wed, 13 Apr 2016 10:03:02 +0000 (11:03 +0100)
committerChristoffer Dall <christoffer.dall@linaro.org>
Fri, 20 May 2016 13:39:39 +0000 (15:39 +0200)
Now that the interface between the arch timer and the VGIC does not
require passing the irq_phys_map entry pointer anymore, let's remove
it from the virtual arch timer and use the virtual IRQ number instead
directly.
The remaining pointer returned by kvm_vgic_map_phys_irq() will be
removed in the following patch.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Eric Auger <eric.auger@linaro.org>
Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
include/kvm/arm_arch_timer.h
virt/kvm/arm/arch_timer.c

index b651aed9dc6b9084ed2dcae8832a033217d4dca4..a47b7dee434dd08d1802c4a285f583b40204e56e 100644 (file)
@@ -53,9 +53,6 @@ struct arch_timer_cpu {
        /* Timer IRQ */
        struct kvm_irq_level            irq;
 
-       /* VGIC mapping */
-       struct irq_phys_map             *map;
-
        /* Active IRQ state caching */
        bool                            active_cleared_last;
 };
index e45895a0153da255fd2e1b5c3583a9461e5d03c2..458d4d8ce7950f5a9dbd2e39d1ac2e9e042ada99 100644 (file)
@@ -175,10 +175,10 @@ static void kvm_timer_update_irq(struct kvm_vcpu *vcpu, bool new_level)
 
        timer->active_cleared_last = false;
        timer->irq.level = new_level;
-       trace_kvm_timer_update_irq(vcpu->vcpu_id, timer->map->virt_irq,
+       trace_kvm_timer_update_irq(vcpu->vcpu_id, timer->irq.irq,
                                   timer->irq.level);
        ret = kvm_vgic_inject_mapped_irq(vcpu->kvm, vcpu->vcpu_id,
-                                        timer->map->virt_irq,
+                                        timer->irq.irq,
                                         timer->irq.level);
        WARN_ON(ret);
 }
@@ -276,7 +276,7 @@ void kvm_timer_flush_hwstate(struct kvm_vcpu *vcpu)
        * exit.
        */
        phys_active = timer->irq.level ||
-                       kvm_vgic_map_is_active(vcpu, timer->map->virt_irq);
+                       kvm_vgic_map_is_active(vcpu, timer->irq.irq);
 
        /*
         * We want to avoid hitting the (re)distributor as much as
@@ -378,7 +378,6 @@ int kvm_timer_vcpu_reset(struct kvm_vcpu *vcpu,
        if (WARN_ON(IS_ERR(map)))
                return PTR_ERR(map);
 
-       timer->map = map;
        return 0;
 }
 
@@ -504,8 +503,7 @@ void kvm_timer_vcpu_terminate(struct kvm_vcpu *vcpu)
        struct arch_timer_cpu *timer = &vcpu->arch.timer_cpu;
 
        timer_disarm(timer);
-       if (timer->map)
-               kvm_vgic_unmap_phys_irq(vcpu, timer->map->virt_irq);
+       kvm_vgic_unmap_phys_irq(vcpu, timer->irq.irq);
 }
 
 void kvm_timer_enable(struct kvm *kvm)