iwlwifi: don't double free the interrupt in failure path
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Tue, 18 Sep 2012 17:48:59 +0000 (19:48 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 19 Sep 2012 00:43:23 +0000 (20:43 -0400)
When the driver can't get the HW ready, we would release
the interrupt twice which made the kernel complain loudly.

Cc: stable@vger.kernel.org
Reported-by: Brian Cockrell <brian.cockrell@intel.com>
Tested-by: Brian Cockrell <brian.cockrell@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwlwifi/pcie/trans.c

index 1e86ea2266d46971844ba5c66a2fb1142a47609d..dbeebef562d5ca0bca0c9b3ac391747ebfe02973 100644 (file)
@@ -1442,6 +1442,7 @@ static int iwl_trans_pcie_start_hw(struct iwl_trans *trans)
        return err;
 
 err_free_irq:
+       trans_pcie->irq_requested = false;
        free_irq(trans_pcie->irq, trans);
 error:
        iwl_free_isr_ict(trans);