USB-EHCI: Delete unnecessary checks before the function call "dma_pool_destroy"
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 16 Nov 2015 18:01:44 +0000 (19:01 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 Dec 2015 22:26:33 +0000 (14:26 -0800)
The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-mem.c

index b6205fac356771bbc2a19ec87cce368e8bc23bce..4de43011df23aa970472eda236edb1e334dad0a3 100644 (file)
@@ -128,21 +128,13 @@ static void ehci_mem_cleanup (struct ehci_hcd *ehci)
        ehci->dummy = NULL;
 
        /* DMA consistent memory and pools */
-       if (ehci->qtd_pool)
-               dma_pool_destroy (ehci->qtd_pool);
+       dma_pool_destroy(ehci->qtd_pool);
        ehci->qtd_pool = NULL;
-
-       if (ehci->qh_pool) {
-               dma_pool_destroy (ehci->qh_pool);
-               ehci->qh_pool = NULL;
-       }
-
-       if (ehci->itd_pool)
-               dma_pool_destroy (ehci->itd_pool);
+       dma_pool_destroy(ehci->qh_pool);
+       ehci->qh_pool = NULL;
+       dma_pool_destroy(ehci->itd_pool);
        ehci->itd_pool = NULL;
-
-       if (ehci->sitd_pool)
-               dma_pool_destroy (ehci->sitd_pool);
+       dma_pool_destroy(ehci->sitd_pool);
        ehci->sitd_pool = NULL;
 
        if (ehci->periodic)