staging: wlan-ng: hfa384x_usb: fix sparse endianness warnings
authorAsaf Vertz <asaf.vertz@tandemg.com>
Sun, 18 Jan 2015 07:11:39 +0000 (09:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Jan 2015 11:59:19 +0000 (19:59 +0800)
Fixed the following warnings (reported by sparse):
drivers/staging/wlan-ng/hfa384x_usb.c:3828:36: warning: cast to restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:3229:16: warning: cast to restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:3430:18: warning: cast to restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:3349:51: warning: restricted __le16 degrades to integer
drivers/staging/wlan-ng/hfa384x_usb.c:3357:37: warning: cast to restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:3358:37: warning: cast to restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:3393:36: warning: cast to restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:3102:28: warning: cast to restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:3004:28: warning: cast to restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:1308:37: warning: cast to restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:2713:25: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:2713:25:    expected unsigned short [unsigned] [usertype] type
drivers/staging/wlan-ng/hfa384x_usb.c:2713:25:    got restricted __le16 [usertype] <noident>

Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlan-ng/hfa384x.h
drivers/staging/wlan-ng/hfa384x_usb.c

index 5b7b4081e2c9317e41b4c0c5ef083238ded158ce..8f2091070491fce457c0e29ffb7ddcf8af61a9f5 100644 (file)
@@ -879,7 +879,7 @@ typedef struct hfa384x_usb_error {
 /* Unions for packaging all the known packet types together */
 
 typedef union hfa384x_usbout {
-       u16 type;
+       __le16 type;
        hfa384x_usb_txfrm_t txfrm;
        hfa384x_usb_cmdreq_t cmdreq;
        hfa384x_usb_wridreq_t wridreq;
@@ -889,7 +889,7 @@ typedef union hfa384x_usbout {
 } __packed hfa384x_usbout_t;
 
 typedef union hfa384x_usbin {
-       u16 type;
+       __le16 type;
        hfa384x_usb_rxfrm_t rxfrm;
        hfa384x_usb_txfrm_t txfrm;
        hfa384x_usb_infofrm_t infofrm;
index 2245339eb6a29609dbb0ba1d96dd6af7883d9e62..28cd1c4c02c8501a07a9791b9126b0a3c83f1b94 100644 (file)
@@ -3346,7 +3346,7 @@ retry:
                if (unlocked_usbctlx_cancel_async(hw, ctlx) == 0)
                        run_queue = 1;
        } else {
-               const u16 intype = (usbin->type & ~cpu_to_le16(0x8000));
+               const __le16 intype = (usbin->type & ~cpu_to_le16(0x8000));
 
                /*
                 * Check that our message is what we're expecting ...