ahci: port_no should be used when clearing IRQ in ahci_thaw()
authorTejun Heo <htejun@gmail.com>
Sat, 27 Jan 2007 02:04:26 +0000 (11:04 +0900)
committerJeff Garzik <jeff@garzik.org>
Sat, 27 Jan 2007 07:50:36 +0000 (02:50 -0500)
ap->id is logcial port ID which is unique among all ATA ports and
doesn't have anything to do with hardware port index.  ap->port_no is
the hardware port index and thus should be used when clearing IRQ mask
in ahci_thaw().

This problem has been spotted by Jeff Garzik <jgarzik@pobox.com>.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/ahci.c

index 28a82e3403f10d074e1d86d69f4b0d69c0546e0a..48616c6fee9d6c30d36f206b60b98707020e0cc8 100644 (file)
@@ -1282,7 +1282,7 @@ static void ahci_thaw(struct ata_port *ap)
        /* clear IRQ */
        tmp = readl(port_mmio + PORT_IRQ_STAT);
        writel(tmp, port_mmio + PORT_IRQ_STAT);
-       writel(1 << ap->id, mmio + HOST_IRQ_STAT);
+       writel(1 << ap->port_no, mmio + HOST_IRQ_STAT);
 
        /* turn IRQ back on */
        writel(DEF_PORT_IRQ, port_mmio + PORT_IRQ_MASK);