staging: octeon-ethernet: disable load balance for receiving packet when CONFIG_RPS...
authorEunbong Song <eunb.song@samsung.com>
Thu, 30 Oct 2014 01:09:00 +0000 (01:09 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Oct 2014 20:32:24 +0000 (13:32 -0700)
It's better disable load balance for receiving packet when CONFIG_RPS is enabled.
If not, octeon-ethernet driver select CPU and then the rps select again CPU.
It can be ipi interrupts overhead and packet reordering could be possible.

Signed-off-by: Eunbong Song <eunb.song@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/octeon/ethernet-rx.c

index b2b6c3cd2bed1701b78495807cd94be04dd1d469..44e372f096837b9e55288239ef3ddded0e74b805 100644 (file)
@@ -286,6 +286,7 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget)
                        did_work_request = 1;
                }
 
+#ifndef CONFIG_RPS
                if (rx_count == 0) {
                        /*
                         * First time through, see if there is enough
@@ -300,6 +301,7 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget)
                        if (backlog > budget * cores_in_use && napi != NULL)
                                cvm_oct_enable_one_cpu();
                }
+#endif
                rx_count++;
 
                skb_in_hw = USE_SKBUFFS_IN_HW && work->word2.s.bufs == 1;