mac_pton: Use bool not int return

Use bool instead of int as the return type.

All uses are tested with !.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 4c52907a6d8b54d41fbd63cc1839f159c0ed5207..a9e2268ecccb0c0f96a02add9b7f122421f223b6 100644 (file)
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -501,7 +501,7 @@ static inline char * __deprecated pack_hex_byte(char *buf, u8 byte)
 extern int hex_to_bin(char ch);
 extern int __must_check hex2bin(u8 *dst, const char *src, size_t count);
 
-int mac_pton(const char *s, u8 *mac);
+bool mac_pton(const char *s, u8 *mac);
 
 /*
  * General tracing related utility functions - trace_printk(),

diff --git a/lib/net_utils.c b/lib/net_utils.c
index 2e3c52c8d050b5ecf21afcd03c5f6d689e99c282..148fc6e99ef63b351977bda6a3b4835e9d24083f 100644 (file)
--- a/lib/net_utils.c
+++ b/lib/net_utils.c
@@ -3,24 +3,24 @@
 #include <linux/ctype.h>
 #include <linux/kernel.h>
 
-int mac_pton(const char *s, u8 *mac)
+bool mac_pton(const char *s, u8 *mac)
 {
        int i;
 
        /* XX:XX:XX:XX:XX:XX */
        if (strlen(s) < 3 * ETH_ALEN - 1)
-               return 0;
+               return false;
 
        /* Don't dirty result unless string is valid MAC. */
        for (i = 0; i < ETH_ALEN; i++) {
                if (!isxdigit(s[i * 3]) || !isxdigit(s[i * 3 + 1]))
-                       return 0;
+                       return false;
                if (i != ETH_ALEN - 1 && s[i * 3 + 2] != ':')
-                       return 0;
+                       return false;
        }
        for (i = 0; i < ETH_ALEN; i++) {
                mac[i] = (hex_to_bin(s[i * 3]) << 4) | hex_to_bin(s[i * 3 + 1]);
        }
-       return 1;
+       return true;
 }
 EXPORT_SYMBOL(mac_pton);